fix: respect executablePath in standalone mode#320
Merged
AlexZeitler merged 1 commit intoPDMLab:masterfrom Mar 11, 2026
Merged
Conversation
cvetkovski98
force-pushed
the
fix/standalone-executable-path
branch
from
efdc1ca to
7e559de
Compare
Contributor
|
@cvetkovski98 Thanks for the PR - new version is available on npm. |
Author
|
@AlexZeitler Thanks for the quick review and merge, appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs and types both allow
{ standalone: true, executablePath: '/path/to/docker-compose' }, but the runtime conditionexecutable?.standalone && !executable.executablePathcauses this combination to fall into the non-standalone branch, which appendscomposeas a subcommand, producing an invalid command like/path/to/docker-compose compose up.We hit this using testcontainers within a hermetic Bazel environment and a docker-compose binary managed by Bazel. The binary lives at a known absolute path (not on PATH), so
standalone: truealone doesn't work, it only searches fordocker-composeon PATH. Setting bothstandaloneandexecutablePathseemed like the obvious solution based on the docs, but silently fell through to the wrong code path.Added new unit tests verifying:
{ standalone: true, executablePath }uses the custom path withoutcompose{ standalone: true }defaults todocker-compose{ executablePath }(non-standalone) still appendscompose(regression test for unchanged behavior)